search

alces-software / metalware

Tools and conventions for improving bare metal machine management
Other
2 stars 0 forks source link

Address #437 with chomp #438

Closed ColonelPanics closed 6 years ago

ColonelPanics commented 6 years ago

This fixes #437

WilliamMcCumstie commented 6 years ago

This looks like a decent fix. However it begs the question on how we deal with the new line characters in general.

I'm of the opinion that SystemCommand is behaving as expected as most system commands do end in a newline character. Thus it is the responsibility of the calling method to chomp the character off.

However, there maybe other cases that don't do this. So we might come across a similar bug again. @bobwhitelock, you have an opinion?

bobwhitelock commented 6 years ago

This looks fine to me for now, but open to being convinced that we should do something else if there's a reason to :slightly_smiling_face:

WilliamMcCumstie commented 6 years ago

I'll merge this through now. We can revisit the issue if it crops up again