search

alchaplinsky / polymer-rails

Polymer and web components for Ruby on Rails
MIT License
286 stars 80 forks source link

Fix the processing of html so that it does not encode src="{{src}}" #43

Closed danshep closed 9 years ago

danshep commented 9 years ago

The escaping that nokogiri does for html attribute values is too aggressive and ends up replacing curly brackets in attribute values. Changed the way the stringify method functions to spit out elements by hand and use ruby's encode method instead to encode the attribute values.

alchaplinsky commented 9 years ago

@danshep could you look at specs and see the reason why output fro processor is different?

danshep commented 9 years ago

It looks like a difference in the libxml c library. Runs fine on my box. Might need to pull up the knowledge as to which tags are self closing.

On Mon, 25 May 2015 10:19 pm Alex Chaplinsky notifications@github.com wrote:

@danshep https://github.com/danshep could you look at specs and see the reason why output fro processor is different?

— Reply to this email directly or view it on GitHub https://github.com/alchapone/polymer-rails/pull/43#issuecomment-105224127 .

alchaplinsky commented 9 years ago

Can you confirm that issue still exists in version 1.0.0? Because I can not reproduce it.