alchaplinsky / polymer-rails

Polymer and web components for Ruby on Rails
MIT License
286 stars 80 forks source link

Update to version "2.0.x" of Polymer #90

Closed claudemircasa closed 7 years ago

claudemircasa commented 7 years ago

Change log

alchaplinsky commented 7 years ago

@lyonmarks Ok, I reviewed your changes, but you updated more files on master in your repo, so they got into this PR. I don't think that latest readme and gemspec changes are meant to go into polymer-rails repo. Could you re-create a PR with only code changes?

claudemircasa commented 7 years ago

I'm sorry @alchaplinsky , I'm still learning about git, I made some modifications to be able to use Polymer version 2 in one of my projects, but it really is not a good idea to add to the master branch because it will generate conflicts. The mistake was mine, I'm new here ;-)

alchaplinsky commented 7 years ago

@lyonmarks no problem, you can just re-build a PR with changes needed for upgrade.