search

alchem0x2A / py-wdf-reader

Python package for read-only accessing the wdf Raman spectroscopy from Ranishaw WiRE software
MIT License
40 stars 16 forks source link

New test files #35

Open alchem0x2A opened 3 years ago

alchem0x2A commented 3 years ago

It would be of great help if more test wdf files can be included in the repo to debug different WiRE versions / data types. @expert-git

expert-main commented 3 years ago

sorry, because of security, I can't share file right now, but I will try.

alchem0x2A commented 3 years ago

I'm definitely fine with that. feel free to close the issue if it is infeasible.

expert-main commented 3 years ago

Thanks for understanding.

ericpre commented 3 years ago

It would be good to add a test suite too. I should be able to help with sourcing test file - I am not acquiring the data myself but I can ask someone else to provide these files.

alchem0x2A commented 3 years ago

@ericpre Thanks for your help!

expert-main commented 3 years ago

I am going to provide more example files, but couldn't push because of file size limit.

expert-main commented 3 years ago

@alchem0x2A I created new PR and uploaded some example files, but I see there are issues on this repo and would like to update.

alchem0x2A commented 3 years ago

hi @expert-git thanks for your file uploads! To keep the size of our repo I would prefer to only provide the wdf files as optional binary release assets for downloading https://github.com/alchem0x2A/py-wdf-reader/releases/tag/binary.

Currently I'm busy with other personal things so updating will be delayed, I'll let you know once there I merge your test files with the master branch. If you have example codes to add please feel free to update your PR. thanks again!

expert-main commented 3 years ago

Thanks for response @alchem0x2A I have got two problems.

expert-main commented 3 years ago

@alchem0x2A I would like to let me know when you are available to connect to discuss about errors. Thanks.