Closed dotsdl closed 2 years ago
Merging #197 (a036582) into master (e2f8c39) will decrease coverage by
0.05%
. The diff coverage is94.73%
.:exclamation: Current head a036582 differs from pull request most recent head 8240e64. Consider uploading reports for the commit 8240e64 to get more accurate results
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 98.20% 98.15% -0.06%
==========================================
Files 24 24
Lines 1340 1352 +12
Branches 290 295 +5
==========================================
+ Hits 1316 1327 +11
Misses 5 5
- Partials 19 20 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/alchemlyb/parsing/util.py | 96.55% <94.73%> (-3.45%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e2f8c39...8240e64. Read the comment docs.
Thank you @dwhswenson for the review! I've implemented changes in response to your feedback.
@dotsdl any chance you can come back to the PR and address remaining comments? Would be nice to get it in.
@orbeckst yes, apologies, was on vacation through middle of last week and looping back to this shortly. Thank you for your review!
I'll get #200 fixed first and then re-run CI here.
@orbeckst danke! :pray:
(The checks had passed before I added everything to CHANGES and I because I need to get some supper, I took a short cut...)
Use in this way requires specifying the compression, if any, that the stream features in order to decompress it.