DrDomenicoMarson commented 2 years ago

This PR removes the useless function any_none() which does the same work as an if None in, and the relative test is removed.

This was suggested in issue #236.

I'm not introducing a check for mbar==None, maintaining the logic as before.

DrDomenicoMarson commented 2 years ago

LGTM. Thanks. Will merge when the tests passes.

That was a quick PR :-)

codecov[bot] commented 2 years ago

Codecov Report

Merging #237 (348df58) into master (ffbf354) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   98.18%   98.18%   -0.01%     
==========================================
  Files          25       25              
  Lines        1656     1651       -5     
  Branches      348      346       -2     
==========================================
- Hits         1626     1621       -5     
  Misses          7        7              
  Partials       23       23

Impacted Files	Coverage Δ
src/alchemlyb/parsing/amber.py	`97.47% <0.00%> (-0.06%)`	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

alchemistry / alchemlyb

replaced useless function "any_none()" with a check for "None in" #237

Codecov Report