alchemistry / alchemlyb

the simple alchemistry library
https://alchemlyb.readthedocs.io
BSD 3-Clause "New" or "Revised" License
197 stars 51 forks source link

Default the plotting unit to None #260

Closed xiki-tempula closed 2 years ago

xiki-tempula commented 2 years ago

Fix #247 Default the unit in plot_dF_state , plot_convergence and plot_ti_dhdl to None. Remove the array input in plot_convergence.

I have fixed the issue here @DrDomenicoMarson

codecov[bot] commented 2 years ago

Codecov Report

Merging #260 (67400a5) into master (316f228) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          26       26           
  Lines        1709     1711    +2     
  Branches      350      352    +2     
=======================================
+ Hits         1686     1688    +2     
  Misses          3        3           
  Partials       20       20           
Impacted Files Coverage Δ
src/alchemlyb/visualisation/convergence.py 100.00% <100.00%> (ø)
src/alchemlyb/visualisation/dF_state.py 95.83% <100.00%> (+0.07%) :arrow_up:
src/alchemlyb/visualisation/ti_dhdl.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

xiki-tempula commented 2 years ago

@orbeckst Thanks for the review. I have added the change log

Is there a test that shows that (1) None works and that (2) changing units works?

I have added this as well.

orbeckst commented 2 years ago

thanks!