alchemistry / alchemlyb

the simple alchemistry library
https://alchemlyb.readthedocs.io
BSD 3-Clause "New" or "Revised" License
189 stars 49 forks source link

Slicing will no longer drop the NaN rows #275

Closed xiki-tempula closed 1 year ago

xiki-tempula commented 1 year ago

Fix #274 The Pre-processing function slicing will not drop NaN rows.

codecov[bot] commented 1 year ago

Codecov Report

Merging #275 (981ac53) into master (03fdc27) will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   98.69%   98.69%   -0.01%     
==========================================
  Files          26       26              
  Lines        1762     1761       -1     
  Branches      379      379              
==========================================
- Hits         1739     1738       -1     
  Misses          3        3              
  Partials       20       20              
Impacted Files Coverage Δ
src/alchemlyb/preprocessing/subsampling.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jhenin commented 1 year ago

Thank you @xiki-tempula and @orbeckst !