alchemistry / alchemlyb

the simple alchemistry library
https://alchemlyb.readthedocs.io
BSD 3-Clause "New" or "Revised" License
189 stars 49 forks source link

Use loguru #303

Closed xiki-tempula closed 1 year ago

xiki-tempula commented 1 year ago

Switch to use loguru for logging Fix #301

xiki-tempula commented 1 year ago

@orbeckst Do you mind have a check to see if you are happy with the new logger? How it works with other section of your code. I'm working on the doc now, where I plan to add a new miscellaneous section to the top level doc and a second level logging. Then in other places, I will just refer to this section.

codecov[bot] commented 1 year ago

Codecov Report

Merging #303 (3b909bf) into master (1d0a111) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   98.75%   98.75%   -0.01%     
==========================================
  Files          27       27              
  Lines        1773     1762      -11     
  Branches      388      388              
==========================================
- Hits         1751     1740      -11     
  Misses          2        2              
  Partials       20       20              
Impacted Files Coverage Δ
src/alchemlyb/estimators/mbar_.py 100.00% <ø> (ø)
src/alchemlyb/convergence/convergence.py 100.00% <100.00%> (ø)
src/alchemlyb/parsing/amber.py 99.15% <100.00%> (-0.01%) :arrow_down:
src/alchemlyb/parsing/namd.py 99.18% <100.00%> (-0.01%) :arrow_down:
src/alchemlyb/workflows/abfe.py 99.67% <100.00%> (-0.01%) :arrow_down:
src/alchemlyb/workflows/base.py 100.00% <100.00%> (ø)
xiki-tempula commented 1 year ago

@orbeckst Thanks for the review. I have addressed the changes.