search

alchemistry / alchemlyb

the simple alchemistry library
https://alchemlyb.readthedocs.io
BSD 3-Clause "New" or "Revised" License
189 stars 49 forks source link

309 make pip test work in m1 mac #310

Closed xiki-tempula closed 1 year ago

xiki-tempula commented 1 year ago

Ok, I got it to work now by changing glob.glob to Path.glob, these two should be the same but Path.glob works fine. I tried pip install -i https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple alchemlyb=="2.0.1" and then pytest --pyargs alchemlyb

Where all tests passed fine.

codecov[bot] commented 1 year ago

Codecov Report

Merging #310 (175dbc4) into master (639969e) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files          26       26           
  Lines        1749     1749           
  Branches      380      380           
=======================================
  Hits         1727     1727           
  Misses          2        2           
  Partials       20       20
Impacted Files Coverage Δ
src/alchemlyb/workflows/abfe.py 99.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

orbeckst commented 1 year ago

please squash-merge yourself when ready, @xiki-tempula

xiki-tempula commented 1 year ago

@orbeckst Sorry I guess I haven't tried other machines. I haven't tried other machines but it hangs on my M1 Mac. As is said in #309. If I pip install the source it works fine. It only hangs when I upload it to pypi and download it to install. I said it is M1 Mac as I got some other issue happening with M1 Mac in other packages so I suspect it is a M1 Mac issue. This is the only glob instance.