Open jaclark5 opened 4 months ago
This is really good! For going forward, might be good to add some dataset to the https://github.com/alchemistry/alchemtest and we can use those file for testing.
Also would be good to add the docs with regard to this as well.
@xiki-tempula
Attention: Patch coverage is 1.37300%
with 431 lines
in your changes missing coverage. Please review.
Project coverage is 80.54%. Comparing base (
f40b89b
) to head (368f314
).
:exclamation: There is a different number of reports uploaded between BASE (f40b89b) and HEAD (368f314). Click for more details.
HEAD has 8 uploads less than BASE
| Flag | BASE (f40b89b) | HEAD (368f314) | |------|------|------| ||16|8|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a Draft I am actively using this and expect it's ready to go, but still needs tests.
Resolves: Issue #349
This module will allow for alchemlyb to be used with LAMMPS outputs. An independent package for easily generating the LAMMPS input files will shortly follow, although the functions have been designed to be flexible.
In addition to the
extract_dHdl
andextract_u_nk
functions, additional functions,extract_dHdl_from_u_n
andextract_u_nk_from_u_n
have been added to allow these data frames to be generated from potential energy information that is separable from the target variable (e.g., epsilon in the LJ).