search

alchemistry / alchemlyb

the simple alchemistry library
https://alchemlyb.readthedocs.io
BSD 3-Clause "New" or "Revised" License
185 stars 49 forks source link

Support matplotlib 3.9.0 #377

Closed xiki-tempula closed 2 weeks ago

xiki-tempula commented 2 weeks ago

Fix https://github.com/alchemistry/flamel/issues/28

xiki-tempula commented 2 weeks ago

@orbeckst Do you mind do a quick review? I will release this version after the PR is merged as this is a critical bug fix.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.83%. Comparing base (584588c) to head (d13bc12).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #377 +/- ## ======================================= Coverage 98.83% 98.83% ======================================= Files 28 28 Lines 1895 1895 Branches 407 407 ======================================= Hits 1873 1873 Misses 2 2 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sidneypaulymer commented 2 weeks ago

LGTM! I reinstalled the bugfix branch into a fresh environment, and flamel now completes without an error. Thanks! My only concern has already been raised: what is the minimum version of matplotlib that will support this change?

xiki-tempula commented 2 weeks ago

minimum version of matplotlib is 3.7.