alchemistry / alchemlyb

the simple alchemistry library
https://alchemlyb.readthedocs.io
BSD 3-Clause "New" or "Revised" License
191 stars 49 forks source link

Prepare for 2.3.2 #390

Closed xiki-tempula closed 2 weeks ago

xiki-tempula commented 3 weeks ago

remove python 3.9 support

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.73%. Comparing base (911ce53) to head (0b9de02). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #390 +/- ## ========================================== - Coverage 98.83% 98.73% -0.11% ========================================== Files 28 28 Lines 1895 1895 Branches 407 407 ========================================== - Hits 1873 1871 -2 Misses 2 2 - Partials 20 22 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xiki-tempula commented 3 weeks ago

Looks like we cannot have any badge in the readme for security reasons. https://github.com/pypa/readme_renderer/issues/304#issuecomment-2259039895

xiki-tempula commented 3 weeks ago

here is the failed pipeline https://github.com/alchemistry/alchemlyb/actions/runs/10537263963/job/29198456637 I can only get it to work by removing the badge

orbeckst commented 3 weeks ago

Can you try replacing .svg in the README badges with .png and not removing them from the PyPi README? This may work without any intermediate conversion magic under the hood and keep our scripts clearer.

xiki-tempula commented 3 weeks ago

@orbeckst I don't think any of the badge support png format https://github.com/alchemistry/alchemlyb/tree/389-release-232-for-joss-publication pypi like it though https://github.com/alchemistry/alchemlyb/actions/runs/10545410402/job/29215582803

orbeckst commented 3 weeks ago

Ah well, thanks for trying it out — I had just manually replaced a svg -> png for I think zenodo and that had worked.

SVG DOI

[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.12692737.svg)](https://doi.org/10.5281/zenodo.12692737)

PNG DOI

[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.12692737.png)](https://doi.org/10.5281/zenodo.12692737)

But for codecov it does not work, as you say: https://codecov.io/gh/alchemistry/alchemlyb/branch/master/graph/badge.png gives indeed


Badge Handler

GET /gh/alchemistry/alchemlyb/branch/master/graph/badge.png

HTTP 404 Not Found
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "detail": "File extension should be one of [ svg || txt ]"
}
xiki-tempula commented 2 weeks ago

@orbeckst Do I need to do something for zenodo or it is done automatically?