search

alchemistry / alchemtest

the simple alchemistry test set
https://alchemtest.readthedocs.io
BSD 3-Clause "New" or "Revised" License
8 stars 12 forks source link

CI: add pypi package check #72

Closed orbeckst closed 2 years ago

orbeckst commented 2 years ago

partially addresses #62

orbeckst commented 2 years ago

our CI is not running on PRs so mainly I want to find out why

codecov[bot] commented 2 years ago

Codecov Report

Merging #72 (6adcd88) into master (5d4dcaf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files          11       11           
  Lines         152      152           
  Branches       19       19           
=======================================
  Hits          137      137           
  Misses         15       15
Flag Coverage Δ
unittests 90.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

orbeckst commented 2 years ago

@xiki-tempula could you have a quick look? I'd like to merge soon, mostly to ensure that we have CI running because at the moment, other PRs such as #71 don't run tests.

orbeckst commented 2 years ago

This would be a very good way of checking of the files are actually being included.

This PR does not really check that all files are included. It only checks that we can build the sdist.

We'd need to build the package, install, run tests for the installed package. Not very difficult but just more than I have time for right now.