search

alchemy-charmers / layer-haproxy

GNU General Public License v3.0
3 stars 1 forks source link

Check #7

Closed chris-sanders closed 5 years ago

chris-sanders commented 5 years ago

This puts the default check behind a feature flag and defaults that flag from the interface to True so it matches current function. The way this is implemented the default value is set in the interface, new charms will just work as expected but existing charms will not get the check until they are rebuilt with the new interface.

That's not ideal, but I didn't really like the idea of enabling 'disable check' and thought it was worth rebuilding a charm or two so that the interface was a bit cleaner. I just wanted to open this for feedback, if this is how we proceed I want to push the change to interface-reverseproxy and then update this branch to use the master branch before merging.

Changes are to the interface, the config file processing, and unit tests.

digitalrane commented 5 years ago

One comment in-line but other than that, LGTM.