alchemy-fr / GeonamesServer

A node Geonames server
Other
43 stars 21 forks source link

Fix JSONP callback lowercase #66

Closed nlegoff closed 10 years ago

nlegoff commented 10 years ago

Fix https://github.com/alchemy-fr/GeonamesServer/issues/65

romainneutron commented 10 years ago

We should not lowercase parameters, that is not fail fast and can introduce such side effects

Romain

On 21 mars 2014, at 17:25, Nicolas Le Goff notifications@github.com wrote:

Fix #65 https://github.com/alchemy-fr/GeonamesServer/issues/65

You can merge this Pull Request by running

git pull https://github.com/nlegoff/GeonamesServer fix-65

Or view, comment on, or merge it at:

https://github.com/alchemy-fr/GeonamesServer/pull/66 Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/alchemy-fr/GeonamesServer/pull/66 .

nlegoff commented 10 years ago

I try to figure out why the hell I introduced this filter ...

nlegoff commented 10 years ago

Indeed there is no reason to modify the user query parameters as it can introduce weird bugs