alchemy-fr / PHP-dataURI

A PHP dataURI library, RFC 2397 Compliant
Other
59 stars 25 forks source link

Add symfony 5.0 dependency #22

Open jfsenechal opened 4 years ago

jfsenechal commented 4 years ago

Hello,

Do you think your library would work with symfony/http-foundation 5.0 ?

Thank you

spackmat commented 4 years ago

I see two occurrences of the HttpFoundation dependency: Both are very simple cases of usage of its File class. So I don't expect any limitations about Symfony 5 compatibility. Is there another reason, why that super simple PR is not accepted since march?

The limitation on Symfony 4 prevents me from updating my project to Symfony 5.1 now (I really don't know why it didn't prevent the Upgrade to 5.0 before, because it should have).

So please could you accept the PR and release a new version?

In the meantime, I used the branch from the PR #23 in my composer.json, by adding the repository and the specific branch:

{
  "repositories": [
    {
      "type": "git",
      "url": "https://github.com/gnutix/PHP-dataURI"
    }
  ],
  "require": {
    "other/dependencies": "^1.0",
    "data-uri/data-uri": "dev-patch-1"
  }
}

Thnaks @gnutix !

ghispi commented 3 years ago

If you just need to get decoded data from data uri use https://www.php.net/manual/en/wrappers.data.php