search

alchemyplatform / rundler

An ERC-4337 Bundler in Rust
GNU Lesser General Public License v3.0
246 stars 29 forks source link

fix(simulation): don't use abi-generated EntryPoint bytecode #698

Closed dphilipson closed 2 months ago

dphilipson commented 2 months ago

This reverts commit 275414d9268997fa9519cdf77d56f88a202e523d.

We need the v0.6 entry point bytecode so we can use it in state overrides during call gas estimation. In a previous commit, we started using bytecode generated by abigen to avoid hardcoding the entry point bytecode or fetching it from on-chain on every run. For unknown reasons, the abigen bytecode is faulty and causes reverts with no data, so switch back to using hardcoded bytecode.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.15%. Comparing base (8eb4cb4) to head (e6d9a59).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/graphs/tree.svg?width=650&height=150&src=pr&token=FQKCPQJU2X&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform)](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | [Files](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | Coverage Δ | | |---|---|---| | [crates/pool/src/chain.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&filepath=crates%2Fpool%2Fsrc%2Fchain.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3Bvb2wvc3JjL2NoYWluLnJz) | `94.78% <100.00%> (ø)` | | | [crates/rpc/src/eth/api.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&filepath=crates%2Frpc%2Fsrc%2Feth%2Fapi.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3JwYy9zcmMvZXRoL2FwaS5ycw==) | `74.20% <100.00%> (ø)` | | | [crates/sim/src/estimation/mod.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&filepath=crates%2Fsim%2Fsrc%2Festimation%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3NpbS9zcmMvZXN0aW1hdGlvbi9tb2QucnM=) | `80.00% <ø> (ø)` | | | [crates/sim/src/estimation/v0\_6.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&filepath=crates%2Fsim%2Fsrc%2Festimation%2Fv0_6.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3NpbS9zcmMvZXN0aW1hdGlvbi92MF82LnJz) | `94.28% <100.00%> (ø)` | | | [crates/sim/src/simulation/v0\_6/context.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&filepath=crates%2Fsim%2Fsrc%2Fsimulation%2Fv0_6%2Fcontext.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3NpbS9zcmMvc2ltdWxhdGlvbi92MF82L2NvbnRleHQucnM=) | `65.58% <ø> (ø)` | | | [crates/types/src/user\_operation/v0\_6.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&filepath=crates%2Ftypes%2Fsrc%2Fuser_operation%2Fv0_6.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3R5cGVzL3NyYy91c2VyX29wZXJhdGlvbi92MF82LnJz) | `97.23% <ø> (ø)` | | | [crates/types/src/validation\_results.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&filepath=crates%2Ftypes%2Fsrc%2Fvalidation_results.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3R5cGVzL3NyYy92YWxpZGF0aW9uX3Jlc3VsdHMucnM=) | `26.95% <ø> (ø)` | | | [crates/rpc/src/eth/events/v0\_6.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&filepath=crates%2Frpc%2Fsrc%2Feth%2Fevents%2Fv0_6.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3JwYy9zcmMvZXRoL2V2ZW50cy92MF82LnJz) | `17.85% <66.66%> (ø)` | | | [crates/dev/src/lib.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&filepath=crates%2Fdev%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL2Rldi9zcmMvbGliLnJz) | `0.00% <0.00%> (ø)` | | | [crates/provider/src/ethers/entry\_point/v0\_6.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree&filepath=crates%2Fprovider%2Fsrc%2Fethers%2Fentry_point%2Fv0_6.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3Byb3ZpZGVyL3NyYy9ldGhlcnMvZW50cnlfcG9pbnQvdjBfNi5ycw==) | `0.00% <0.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | | | [Flag](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `55.15% <47.36%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | Coverage Δ | | |---|---|---| | [rundler binary](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `0.00% <0.00%> (ø)` | | | [builder](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `50.60% <ø> (ø)` | | | [dev](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `0.00% <0.00%> (ø)` | | | [pool](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `64.87% <100.00%> (ø)` | | | [provider](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `14.77% <0.00%> (ø)` | | | [rpc](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `25.46% <75.00%> (ø)` | | | [sim](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `77.53% <100.00%> (ø)` | | | [tasks](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `∅ <ø> (∅)` | | | [types](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `65.88% <ø> (ø)` | | | [utils](https://app.codecov.io/gh/alchemyplatform/rundler/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `18.28% <ø> (ø)` | |