alchemyplatform / rundler

An ERC-4337 Bundler in Rust
GNU Lesser General Public License v3.0
246 stars 29 forks source link

fix(provider): use state overrides for gas used, not ctor method #706

Closed dancoombs closed 1 month ago

dancoombs commented 1 month ago

Proposed Changes

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 36.75214% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 55.22%. Comparing base (58f31f4) to head (b6ce4c7).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/graphs/tree.svg?width=650&height=150&src=pr&token=FQKCPQJU2X&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform)](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | [Files](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | Coverage Δ | | |---|---|---| | [crates/builder/src/bundle\_proposer.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&filepath=crates%2Fbuilder%2Fsrc%2Fbundle_proposer.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL2J1aWxkZXIvc3JjL2J1bmRsZV9wcm9wb3Nlci5ycw==) | `89.02% <100.00%> (-0.02%)` | :arrow_down: | | [crates/provider/src/traits/provider.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&filepath=crates%2Fprovider%2Fsrc%2Ftraits%2Fprovider.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3Byb3ZpZGVyL3NyYy90cmFpdHMvcHJvdmlkZXIucnM=) | `100.00% <ø> (ø)` | | | [...es/sim/src/estimation/estimate\_verification\_gas.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&filepath=crates%2Fsim%2Fsrc%2Festimation%2Festimate_verification_gas.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3NpbS9zcmMvZXN0aW1hdGlvbi9lc3RpbWF0ZV92ZXJpZmljYXRpb25fZ2FzLnJz) | `95.97% <100.00%> (+0.05%)` | :arrow_up: | | [crates/sim/src/estimation/v0\_6.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&filepath=crates%2Fsim%2Fsrc%2Festimation%2Fv0_6.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3NpbS9zcmMvZXN0aW1hdGlvbi92MF82LnJz) | `94.40% <100.00%> (-0.01%)` | :arrow_down: | | [crates/sim/src/utils.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&filepath=crates%2Fsim%2Fsrc%2Futils.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3NpbS9zcmMvdXRpbHMucnM=) | `94.11% <ø> (+0.17%)` | :arrow_up: | | [crates/types/src/chain.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&filepath=crates%2Ftypes%2Fsrc%2Fchain.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3R5cGVzL3NyYy9jaGFpbi5ycw==) | `88.88% <100.00%> (ø)` | | | [crates/rpc/src/task.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&filepath=crates%2Frpc%2Fsrc%2Ftask.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3JwYy9zcmMvdGFzay5ycw==) | `0.00% <0.00%> (ø)` | | | [crates/types/src/user\_operation/v0\_6.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&filepath=crates%2Ftypes%2Fsrc%2Fuser_operation%2Fv0_6.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3R5cGVzL3NyYy91c2VyX29wZXJhdGlvbi92MF82LnJz) | `95.22% <0.00%> (-2.04%)` | :arrow_down: | | [crates/types/src/user\_operation/mod.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&filepath=crates%2Ftypes%2Fsrc%2Fuser_operation%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3R5cGVzL3NyYy91c2VyX29wZXJhdGlvbi9tb2QucnM=) | `62.23% <0.00%> (-3.13%)` | :arrow_down: | | [crates/types/src/user\_operation/v0\_7.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree&filepath=crates%2Ftypes%2Fsrc%2Fuser_operation%2Fv0_7.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3R5cGVzL3NyYy91c2VyX29wZXJhdGlvbi92MF83LnJz) | `64.55% <0.00%> (-1.23%)` | :arrow_down: | | ... and [2 more](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | | | [Flag](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `55.22% <36.75%> (-0.21%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | Coverage Δ | | |---|---|---| | [rundler binary](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `0.00% <ø> (ø)` | | | [builder](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `49.79% <100.00%> (-0.04%)` | :arrow_down: | | [dev](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `0.00% <ø> (ø)` | | | [pool](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `64.50% <ø> (ø)` | | | [provider](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `16.68% <0.00%> (-0.32%)` | :arrow_down: | | [rpc](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `25.67% <0.00%> (-0.31%)` | :arrow_down: | | [sim](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `77.99% <100.00%> (-0.05%)` | :arrow_down: | | [tasks](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `∅ <ø> (∅)` | | | [types](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `66.27% <3.44%> (-1.06%)` | :arrow_down: | | [utils](https://app.codecov.io/gh/alchemyplatform/rundler/pull/706/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `18.28% <ø> (ø)` | |