alchemyplatform / rundler

An ERC-4337 Bundler in Rust
GNU Lesser General Public License v3.0
246 stars 29 forks source link

fix(sim): handle v0.7 executeUserOp special call in call gas estimation #715

Closed dancoombs closed 3 weeks ago

dancoombs commented 3 weeks ago

Proposed Changes

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 84.55285% with 19 lines in your changes missing coverage. Please review.

Project coverage is 55.20%. Comparing base (07f6699) to head (c275a63).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/graphs/tree.svg?width=650&height=150&src=pr&token=FQKCPQJU2X&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform)](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | [Files](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | Coverage Δ | | |---|---|---| | [crates/sim/src/estimation/estimate\_call\_gas.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715?src=pr&el=tree&filepath=crates%2Fsim%2Fsrc%2Festimation%2Festimate_call_gas.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3NpbS9zcmMvZXN0aW1hdGlvbi9lc3RpbWF0ZV9jYWxsX2dhcy5ycw==) | `96.12% <100.00%> (-0.87%)` | :arrow_down: | | [crates/sim/src/estimation/v0\_6.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715?src=pr&el=tree&filepath=crates%2Fsim%2Fsrc%2Festimation%2Fv0_6.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3NpbS9zcmMvZXN0aW1hdGlvbi92MF82LnJz) | `94.63% <100.00%> (+0.23%)` | :arrow_up: | | [crates/sim/src/estimation/v0\_7.rs](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715?src=pr&el=tree&filepath=crates%2Fsim%2Fsrc%2Festimation%2Fv0_7.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#diff-Y3JhdGVzL3NpbS9zcmMvZXN0aW1hdGlvbi92MF83LnJz) | `80.42% <64.81%> (-1.59%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | [Flag](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `55.20% <84.55%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | Coverage Δ | | |---|---|---| | [rundler binary](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `0.00% <ø> (ø)` | | | [builder](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `50.00% <ø> (ø)` | | | [dev](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `0.00% <ø> (ø)` | | | [pool](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `64.37% <ø> (ø)` | | | [provider](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `16.68% <ø> (ø)` | | | [rpc](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `25.67% <ø> (ø)` | | | [sim](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `77.86% <84.55%> (-0.08%)` | :arrow_down: | | [tasks](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `∅ <ø> (∅)` | | | [types](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `65.45% <ø> (-0.51%)` | :arrow_down: | | [utils](https://app.codecov.io/gh/alchemyplatform/rundler/pull/715/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alchemyplatform) | `18.28% <ø> (ø)` | |