search

alchemyst / Skogestad-Python

Python code for "Multivariable Feedback Control"
111 stars 88 forks source link

Remove tf class from utils #307

Open alchemyst opened 6 years ago

alchemyst commented 6 years ago

The tf class is perhaps reaching the end of its usefulness. We don't really need to maintain a whole separate class from the ones found in control and harold or sympy.

DeonDataScience commented 6 years ago

This does not seem that difficult to accomplish. I will work on this.

WillemASmit commented 5 years ago

@DeonPMC how far did you get with this issue? @alchemyst inherently the mimotf class will also have to be removed?

alchemyst commented 5 years ago

@WillemASmit I am actually torn on this as right now neither of the linked libraries have the ability to handle dead time. This is a major stumbling block, so closing this issue probably will also require contributing support for delays to one of the other libraries.

ilayn commented 5 years ago

✅ Dead time feature request noted :)

alchemyst commented 5 years ago

@ilayn You're too quick!

DeonDataScience commented 5 years ago

I never got around to changing this. In my opinion there is little reason to change the tf and mimotf classes. The greatest part of the code-base is dependent on these objects.