search

alchemyst / Skogestad-Python

Python code for "Multivariable Feedback Control"
111 stars 88 forks source link

Minor RGA and scaling fix #309

Closed DeonDataScience closed 6 years ago

DeonDataScience commented 6 years ago

Fixed minor error in scaling if Gd_hat and d is present. Improved robustness of RGA matrix input.

alchemyst commented 6 years ago

Under what conditions would d not be equivalent to d is not None in this code? When would you pass a d which is falsy?

DeonDataScience commented 6 years ago

I received the error when Gd_hat and d were present. "The truth of an array with more than one element is ambiguous." Is not None sort of cuts that out, because Gd_hat and d are matrices.

On Apr 3, 2018 8:20 AM, "Carl Sandrock" notifications@github.com wrote:

Under what conditions would d not be equivalent to d is not None in this code? When would you pass a d which is falsy https://docs.python.org/3/library/stdtypes.html#truth-value-testing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alchemyst/Skogestad-Python/pull/309#issuecomment-378140486, or mute the thread https://github.com/notifications/unsubscribe-auth/AXX4Iny0LTdMh7o5ESr9Zup-4p197h3Gks5tkxSTgaJpZM4TEfNL .

-- This message and attachments are subject to a disclaimer. Please refer to http://www.it.up.ac.za/documentation/governance/disclaimer/ for full details.

alchemyst commented 6 years ago

That makes sense. We should then change both checks to is not None.

-- This message may contain unintentional errors, as it was typed on a phone

On 03 Apr 2018, at 08:26, Deon Pretorius notifications@github.com wrote:

I received the error when Gd_hat and d were present. "The truth of an array with more than one element is ambiguous." Is not None sort of cuts that out, because Gd_hat and d are matrices.

On Apr 3, 2018 8:20 AM, "Carl Sandrock" notifications@github.com wrote:

Under what conditions would d not be equivalent to d is not None in this code? When would you pass a d which is falsy https://docs.python.org/3/library/stdtypes.html#truth-value-testing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alchemyst/Skogestad-Python/pull/309#issuecomment-378140486, or mute the thread https://github.com/notifications/unsubscribe-auth/AXX4Iny0LTdMh7o5ESr9Zup-4p197h3Gks5tkxSTgaJpZM4TEfNL .

-- This message and attachments are subject to a disclaimer. Please refer to http://www.it.up.ac.za/documentation/governance/disclaimer/ for full details. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.