Add Euclid simplification algorithm to tf class

alchemyst / Skogestad-Python

Python code for "Multivariable Feedback Control"

111 stars 88 forks source link

Add Euclid simplification algorithm to tf class #332

Closed AlgorithmicAmoeba closed 5 years ago

AlgorithmicAmoeba commented 5 years ago

It should replace the simplify function in the tf class. Uses the algorithm found here: https://en.wikipedia.org/wiki/Polynomial_greatest_common_divisor#Euclidean_algorithm

I also added a test for it, which it passes. Although the tests are not exhaustive.

AlgorithmicAmoeba commented 5 years ago

I see that it is failing the travis CI build. I will look into it.

alchemyst commented 5 years ago

Also look back in the commit history at before we started doing pole zero calculation eagerly. There was a perfectly working gcd implementation in there IIRC.