search

alcohol / iso3166

A PHP library providing ISO 3166-1 data.
https://iso3166.thephpleague.com
MIT License
640 stars 59 forks source link

New version? #39

Closed enumag closed 7 years ago

enumag commented 7 years ago

I see that the stable version 1.0.x has a different API than the master branch:

// 1.0.x
$data = (new League\ISO3166\ISO3166)->getByAlpha2($alpha2);
// master
$data = (new League\ISO3166\ISO3166)->alpha2($alpha2);

The documentation describes the master API with no hint that it is different in stable.

Also the documentation should contain an example of what the $data variable contains.

alcohol commented 7 years ago

Yeah I should get around to tagging a new version. I think I was just about done with the changes I had in mind, but then a lot of other projects and work came up and I kind of forgot..

alcohol commented 7 years ago

Tagged 2.0.0.