alcohol / iso3166

A PHP library providing ISO 3166-1 data.
https://iso3166.thephpleague.com
MIT License
649 stars 60 forks source link

needs documentation #5

Open alcohol opened 8 years ago

alcohol commented 8 years ago

I'm considering (either, or both) the following 2 options:

robjbrain commented 8 years ago

Any chance of getting some documentation on this? It's not at all clear how to use it as it stands?

alcohol commented 8 years ago

The chance is quite high. It is more a question of when. I have limited time available. Anyone can contribute this if they want to. Simply add relevant document(s) to the docs folder.

The first thing that should be documented is the interface (it is really quite trivial), which can be found in DataProvider.php.

After that, documentation can be extended to include details about how to load a customized dataset and such (but this is less important, cause anyone going down this path can probably figure it out from the code themselves).

davidjeddy commented 8 years ago

Idea: Run phpDocumentor over the project and publish to gh-pages? I know it is not an all inclusive solution but would provide a start. I'd be happy to do this for you @alcohol.

alcohol commented 8 years ago

That only provides a very basic API summary. I've added the interface methods already. You're free to add the phpdoc output to the existing docs. See the docs directory. I don't publish the docs through a gh-pages branch, since that is no longer necessary after the changes Github introduced.

davidjeddy commented 8 years ago

Per comment on https://github.com/thephpleague/iso3166/pull/30#issuecomment-249880823 ; what did you have in mind for documentation?

alcohol commented 8 years ago

Just another one or two pages on top of what is currently in docs/. A very brief description of the methods, their signature, and perhaps explaining what they do (if it isn't obvious from the name and signature yet).

davidjeddy commented 8 years ago

Ah, ok. Now I understand what you were looking for.