search

alcohol / iso3166

A PHP library providing ISO 3166-1 data.
https://iso3166.thephpleague.com
MIT License
649 stars 60 forks source link

country code for kosovo is added #54

Closed galion96 closed 4 years ago

galion96 commented 4 years ago

it appears that library does not have support for iso3code for Kosovo, and since the class is marked final it can not be extended to add the data manually

alcohol commented 4 years ago

https://en.wikipedia.org/wiki/Kosovo still considers Kosovo to be disputed and there is no official code in the standard, only a user assigned one.

https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2 states

The code XK is being used by the European Commission, the IMF, and SWIFT, CLDR and other organizations as a temporary country code for Kosovo.

So I'm reluctant to add it, since it is not yet part of the official standard.

galion96 commented 4 years ago

I understand, what do you think about not making the class final, so it can be extended if someone wants to add some "disputed" countries or ect

alcohol commented 4 years ago

I see no reason to remove the final. While you cannot extend it, you can still wrap it. The difference is minor, if not nihil.

galion96 commented 4 years ago

Thats what I already did was just a suggestion, thanks and I will mark this resolved.