search

alcohol / iso3166

A PHP library providing ISO 3166-1 data.
https://iso3166.thephpleague.com
MIT License
640 stars 59 forks source link

Include other countries #55

Closed paolooo closed 3 years ago

paolooo commented 3 years ago

Hi,

Is it possible to include other countries such as countries of the UK - England, Scotland, Wales, and Northern Ireland?

I can see those countries in wiki (see the link below) but it doesn't have some ISO 3166-1 and 3166-2 data. https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes

Thoughts?

alcohol commented 3 years ago

If you really want those additional "countries", you can always decorate this library with your own class to extend the dataset.

paolooo commented 3 years ago

Ok, thanks. :)

alexandrmazur96 commented 1 year ago

you can always decorate this library with your own class to extend the dataset.

Just to be honest - he can't. No one can – https://3v4l.org/2mVuc#v8.2.5

The dataset in ISO3166 has a private visibility modifier - https://github.com/thephpleague/iso3166/blob/74a08ffe08d4e0dd8ab0aac8c34ea5a641d57669/src/ISO3166.php#L160

alcohol commented 1 year ago

You're talking about extending, not decorating.