search

alcohol / iso3166

A PHP library providing ISO 3166-1 data.
https://iso3166.thephpleague.com
MIT License
640 stars 59 forks source link

Php8 support #57

Closed Nielsvanpach closed 3 years ago

Nielsvanpach commented 3 years ago

In order to support PHP 8, we have to upgrade PHPUnit to v9. This is the only version supporting PHP 8.0. I had to refactor the tests a bit because of incompatibilities and deprecations. This also means we have to require php ^7.3.

It would be great to see this package support PHP 8!

Also, no green checkmark shown here but you can see the tests passed on my fork: https://github.com/Nielsvanpach/iso3166/commits/php8-support

alcohol commented 3 years ago

Thanks a lot for your time and work; I will try to make some time tonight myself to take a closer look.

Nielsvanpach commented 3 years ago

@pimjansen I did not make any style changes myself. These were done by the php-cs fixer action, which uses the config file .php_cs.dist that was already present in this repo. I assume the command was not run in a while.