search

alcohol / iso3166

A PHP library providing ISO 3166-1 data.
https://iso3166.thephpleague.com
MIT License
640 stars 59 forks source link

Added `ReturnTypeWillChange` for php8.1 compatibility #72

Closed jakubvojacek closed 2 years ago

jakubvojacek commented 2 years ago

Hello

can you please check this? It throws deprecation warnings without those (i didnt want to add proper return type as that would break backward compatibility)

Thanks

alcohol commented 2 years ago

Honestly I am behind on the latest features since my client is still stuck on 7.1 and I barely have time for open source work. But quickly looking at what this attribute is for, I am not sure I understand why it is necessary. The methods you added it to already declare their return types, and as far as I know, those are correct?

jakubvojacek commented 2 years ago

wow, i must be blind, sorry, i was running 3.x version and didnt notice there was already release to 4.x where proper types were added.

Once again, I am sorry for your time!

alcohol commented 2 years ago

No worries, these things can happen :-)