Rework. More OO friendly interface.

[makasim]

Changes:

• Make all current methods getByXXX and getAll static.
• As well as currencies property.
• Rename all getByXX methods to findByXXX ones.
• Rename getAll to findAll method.
• Now all find method returns instance of ISO4217 with some nice getters.

Code:

<?php

$euro = new \Alcohol\ISO4217::findByAlpha3('EUR');

// or

$euro = new \Alcohol\ISO4217::findByNumeric('978');

$euro->getName();    // Euro
$euro->getAlpha3();  // EUR
$euro->getNumeric(); // 978
$euro->getExp();     // 2
$euro->getCountry(); // ['AD', 'AT' ... 'YT', 'ZW']

TODO:

• identity map

[makasim]

@alcohol ping

[makasim]

Background, I want to use this library in Payum.

[alcohol]

Hi @makasim. While I appreciate your consideration for using my library in your project, I have some concerns with this pull request.

• I'm not sure why you felt obligated to change all the method names (I imagine it is related to some kind of naming convention you are following), but this makes it very unappealing for me to merge this change. The proposed changes break backwards compatibility for pretty much every method definition, without any actual benefit or purpose.
• I intentionally return a simple data array from each method. This leaves room for the end user to model it as an object/entity, in whatever form they might desire. I do not wish to impose a particular object, entity, or anything of that kind from my end.

As it stands right now, I will not be merging this pull request in it's current form. I'm sorry if this inconveniences your attempt to integrate my library in your project.

[makasim]

Okay, I will copy\paste classes to my own code base.

Thanks.