Separated the data from the class. Created a Factory for class.

alcohol / iso4217

ISO 4217 PHP Library

MIT License

142 stars 21 forks source link

Separated the data from the class. Created a Factory for class. #19

Closed staffanselander closed 6 years ago

staffanselander commented 6 years ago

I have separated the underlying data from the ISO4217 class. I have also created a factory for creating instances of ISO4127.

alcohol commented 6 years ago

Is there a rationale behind this...? As it is right now, you've complete changed the API, which would require a new major version release, without any reason (you might have a valid reason, but you did not share it).