alcounit / selenosis

Scalable, stateless selenium hub for Kubernetes cluster
Apache License 2.0
81 stars 24 forks source link

Long pod name after moving image to ECR #33

Closed shlomitsur closed 3 years ago

shlomitsur commented 3 years ago

Hello @alcounit! To avert the rate-limit I've moved the images (selenosis, seleniferous, chrome) to ecr. selenosis & seleniferous works well but the chrome pods are failing because the pod name is longer than 63 characters:

"failed to start browser: failed to create pod Pod \"543052680787-dkr-ecr-us-west-2-amazonaws-com-chrome-89-0-e2f3f465-a0f4-42a1-8e56-b88ca0e35f6d\" is invalid: [metadata.labels: Invalid value: \"543052680787-dkr-ecr-us-west-2-amazonaws-com-chrome-89-0-e2f3f465-a0f4-42a1-8e56-b88ca0e35f6d\": must be no more than 63 characters, spec.hostname: Invalid value: \"543052680787-dkr-ecr-us-west-2-amazonaws-com-chrome-89-0-e2f3f465-a0f4-42a1-8e56-b88ca0e35f6d\": must be no more than 63 characters]"

browser.yaml:

chrome:
  defaultVersion: "89.0"
  path: "/"
  kernelCaps:
  - SYS_ADMIN
  versions:
    '89.0':
      image: 543037328387.dkr.ecr.us-west-2.amazonaws.com/chrome:89.0
      spec:
        resources:
          requests:
            memory: 1Gi
            cpu: '1'
          limits:
            memory: 1Gi
            cpu: '1'

Thank you

alcounit commented 3 years ago

@shlomitsur thanks, will fix it soon.

alcounit commented 3 years ago

@shlomitsur please try alcounit/selenosis:v1.0.3

shlomitsur commented 3 years ago

Thanks @alcounit for the quick fix, I'll apply it once we'll pass peak-hours in the us.

shlomitsur commented 3 years ago

@alcounit thanks it works well