alcpereira / cv-generator

Generate a PDF with React
MIT License
31 stars 12 forks source link

design system: Convert to CSS variables #1

Open alcpereira opened 7 months ago

alcpereira commented 7 months ago

Description

To change any spacing/color/etc, it's currently needed to go into the component themselves. With the introduction of the templates/themes, the only viable way would be to have CSS variables.

Note: This might be broken down into several PRs/Issues.

Example:

.bubble {
  border: 1px solid var(--light-grey);
}

should become

.bubble {
  border: var(--bubble-border);
}

with

:root {
  /* Main colors first*/
  --color-700: rgb(94, 90, 94);

  --bubble-border: 1px solid var(--color-700);
}

(Color variables naming will change with this issue)

Acceptance criteria

flufynarwhal commented 1 month ago

I can work on this starting on Monday.