alcpereira / cv-generator

Generate a PDF with React
MIT License
33 stars 14 forks source link

Remove `normalize.css` and refactor into `index.css` #13

Open alcpereira opened 9 months ago

alcpereira commented 9 months ago

Description

For rapid prototyping, we used a normalize.css and let the original index.css. Normalize is targeting some things that we don't need, we should have only what is needed in index.css

ACs

gabrielpenteado commented 3 months ago

I am working on removing what is unnecessary, then deleting normalize.css, and finally refactoring the code in index.css.

flufynarwhal commented 1 month ago

Hey Gab, what is your discord? I was wondering if you could show me what did you do to refractor normalize.css and how did you tell what is unnecessary and what not?

gabrielpenteado commented 1 month ago

Hi, I need to ask more about this issue. I thought of two paths, one more time-consuming and another faster. Alexandre can give us an indication of the most suitable solution. My discord is Gapent. The faster and more automated option would be to use PurgeCSS tool to remove unused CSS :) And the other way is: 1- Identify the necessary styles: This involves reviewing the code to determine which specific styles from the normalize.css file are actually being used and are essential for the layout and functionality. 2- Creating a new-normalize.css file with only the necessary code for the correct functioning of styles and functionalities 3- Test the code to ensure it doesn't break any styles 4- Refactor the index.css file with the code from new-normalize.css and delete it or import the new-normalize.css into index.css