Validate MIDI range, (fixes #69)

alda-lang / alda-core

The core machinery of Alda

80 stars 26 forks source link

Validate MIDI range, (fixes #69) #73

Closed iggar closed 3 years ago

iggar commented 5 years ago

(This fixes #69) Validate MIDI range, raise exception when out of range. Replace 'if' with more idiomatic 'when'. Tidy up code. Add note_test. Note: on alda.lisp.events.note-test I've managed to add the positive case test ("happy path") but I couldn't figure out the negative test case, when the exception is thrown. So I left it commented out for discussion. I'm happy to make further changes, e.g. the text on the message to be shown

daveyarwood commented 5 years ago

Hey @iggar , thanks for the PR! This looks like it should do the trick. Nice work so far. I've left some comments/suggestions.

daveyarwood commented 3 years ago

At this point in the saga of Alda, the focus has shifted to a new v2 branch implemented in Go and Kotlin. Alda v2 will be released soon (:crossed_fingers: ) so I think we can close the PR at this point. I am keeping the associated issue open for now until I can confirm the same issue is fixed in Alda v2.