alda-lang / alda

A music programming language for musicians. :notes:
https://alda.io
Eclipse Public License 2.0
5.61k stars 288 forks source link

update the shell file #457

Closed ragu-1997 closed 1 year ago

ragu-1997 commented 1 year ago

shell module(label: low-hanging-fruit)

ragu-1997 commented 1 year ago

Hi Alda,

Can you give me reason for spam because of my learning perspective. Possible to remove the spam Flag because I want contribute more am a fresher .

Happy learning 🎉

On Mon, Oct 10, 2022, 6:28 PM Dave Yarwood @.***> wrote:

Closed #457 https://github.com/alda-lang/alda/pull/457.

— Reply to this email directly, view it on GitHub https://github.com/alda-lang/alda/pull/457#event-7553883885, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATLYDUIVHZAIQ5EQDMB2VETWCQHF3ANCNFSM6AAAAAARBBKTCQ . You are receiving this because you authored the thread.Message ID: @.***>

daveyarwood commented 1 year ago
ragu-1997 commented 1 year ago

Thanks for your time Alda now am understand . can you remove spam Flag because I want to participate.sorry for that

On Tue, Oct 11, 2022, 6:32 PM Dave Yarwood @.***> wrote:

  • Adding exit 0 to the end of a shell script does not change the behavior of the shell script at all. Shell scripts always exit 0 by default if they make it to the end without exiting with another status
  • Adding exit 0 to the end of a shell script is not idiomatic Bash.
  • Adding exit 0 to the end of the script does not provide any additional value over what the script is already doing.
  • This PR does not address any of the issues that I have labeled hacktoberfest.

— Reply to this email directly, view it on GitHub https://github.com/alda-lang/alda/pull/457#issuecomment-1274654592, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATLYDULR7VU2YPQZMVIGO33WCVQPDANCNFSM6AAAAAARBBKTCQ . You are receiving this because you authored the thread.Message ID: @.***>

ragu-1997 commented 1 year ago
  • Adding exit 0 to the end of a shell script does not change the behavior of the shell script at all. Shell scripts always exit 0 by default if they make it to the end without exiting with another status
  • Adding exit 0 to the end of a shell script is not idiomatic Bash.
  • Adding exit 0 to the end of the script does not provide any additional value over what the script is already doing.
  • This PR does not address any of the issues that I have labeled hacktoberfest.

Hey dav, It's not kind of spam just a package please consider remove the spam tag