aldabil21 / react-scheduler

React scheduler component based on Material-UI & date-fns
The Unlicense
353 stars 127 forks source link

Draggable property is ignored on custom event renderer #298

Closed vineettadakamalla closed 8 months ago

vineettadakamalla commented 8 months ago
          1. you have typo `draggabe`, should be `draggable`.
  1. It will not work when you do props.draggable = false, then you also spread the {...props}. This will override it.
  2. If you don't want it to be draggable,you can ignore spearding the props

Here is your example event in a snadbox: https://codesandbox.io/p/sandbox/standard-forked-slkl8m?file=%2Fsrc%2FApp.js

Originally posted by @aldabil21 in https://github.com/aldabil21/react-scheduler/issues/297#issuecomment-1896253636

vineettadakamalla commented 8 months ago

@aldabil21 - I appreciate the quick responses. I will remove the spread {...props}

Sorry to reopen the issue, I was still able to drag it in the sandbox example.

It is not apparent at first, but if you long press on the event, it becomes draggable. Here is a screenshot of me dragging it and it throws an error after dragging though.

image

image

aldabil21 commented 8 months ago

I took more time to check this. There is no dragging issue within the eventItem it self. Event item is not draggable. But you can long press and drag the entire row or multiple cells togather, which may cause this issue.

This is a different kind of a bug, not related to your issue. I will see how can I fix this

aldabil21 commented 8 months ago

Check version 2.8.2