search

aldanor / fast-float-rust

Super-fast float parser in Rust (now part of Rust core)
https://docs.rs/fast-float
Apache License 2.0
274 stars 20 forks source link

New release on crates.io #35

Open x-hgg-x opened 2 years ago

x-hgg-x commented 2 years ago

Hello, can you make a new release on crates.io which includes the fix for #28 ?

Shnatsel commented 1 year ago

@aldanor could you publish a new release of fast-float to crates.io with the fix for https://github.com/aldanor/fast-float-rust/issues/28?

I understand the fix is already merged and you just need to cargo publish.

jqnatividad commented 1 month ago

+1 on a new release please @aldanor .

It's been more than 4 years since 0.2.0 was released and there are still pending unreleased fixes.

Alexhuszagh commented 1 month ago

Would there be interest in me forking this and maintaining it as fast-float2? I'm the external contributor I believe who has done the most work on this and it seems this is no longer maintained, so I could merge the pending PRs and issue fixes and draft additional releases.

Ideally, users could just migrate to Rust std library implementation but for partial float parsing, that would be a nice alternative.

Alexhuszagh commented 1 month ago

This has been forked @jqnatividad to fast-float2. It currently has no changes other than a migration to 0.2.1 and the patches mentioned here. I'll add additional patches for the unsoundness soon. I'll submit a PR to rustsec about this and potentially detach my fork in the future.

https://github.com/Alexhuszagh/fast-float-rust https://crates.io/crates/fast-float2

jqnatividad commented 1 month ago

Thanks @Alexhuszagh ! This crate is widely used by other high-visibility crates like polars. https://crates.io/crates/fast-float/reverse_dependencies

Thanks for stepping up!

Alexhuszagh commented 1 month ago

I need to do a few security soundness patches related to #37 which should be relatively trivial to implement just to ensure local safety invariants are met.