search

aldanor / hdf5-rust

HDF5 for Rust
https://docs.rs/hdf5
Apache License 2.0
310 stars 85 forks source link

Fix deadlock on init #175

Closed mulimoen closed 3 years ago

mulimoen commented 3 years ago

This should always initialise the library correctly without dead-locking when nesting LIBRARY_INIT and LOCK

Fixes #174

aldanor commented 3 years ago

That's great! Yea, that should fix it. Maybe update the changelog as well (in the 'fixed' section)? Or is it something we have introduced past 0.7.1?

(Few cosmetic comments aside, looks good to go if it's all green)

mulimoen commented 3 years ago

We introduced the deadlock when we started silencing errors and modifying the globals, but it has been present in some variant earlier by not calling H5Open in certain cases. Fixes were accepted and commited, thanks!

aldanor commented 3 years ago

👍 Great. I'll rebase my loc branch on that then and push it shortly