search

aldanor / hdf5-rust

HDF5 for Rust
https://docs.rs/hdf5
Apache License 2.0
310 stars 84 forks source link

Support hdf5 1.14.0 #227

Closed mulimoen closed 1 year ago

mulimoen commented 1 year ago

The work done to support 1.13.0 means 1.14.0 is trivial to support

jan-kaspar commented 1 year ago

Hi all, what is the status of this PR? I'd be very grateful for the support of 1.14...

BTW: could one ignore the "patch" part here: https://github.com/aldanor/hdf5-rust/blob/master/hdf5-sys/build.rs#L32 ? For example on ArchLinux there is just a number after the dash, https://archlinux.org/packages/community/x86_64/hdf5/, thus failing the regex.

Many thanks in advance!

aldanor commented 1 year ago

@mulimoen I'll take a look at this (and other PRs) on the weekend, is h5d the only change here?

mulimoen commented 1 year ago

@aldanor Yes, everything else is covered by the support for 1.13

We should probably remove support for 1.13 at some point considering odd minor versions are "test" versions

mulimoen commented 1 year ago

Patched versions in e.g. Arch linux currently has the version number "1.14.1-2" which should now be supported

aldanor commented 1 year ago

Looks good, thanks! Unless there's anything else to be done here I'll merge this so we can proceed forward.

aldanor commented 1 year ago

Just double checking - would this close https://github.com/aldanor/hdf5-rust/issues/230? (I guess so)

mulimoen commented 1 year ago

Feel free to merge. I'll prepare something to rid us of 1.13 later