Open CramBL opened 4 months ago
Is it safe to add these config options when not cross compiling?
So I forked the repo and added the above config options to the build.rs file and it works fine when building in the repo but the configuration options seem to have no affect when I patch my project with my fork for hdf5-src, do you know what may be going on?
@Isaac-Leonard Does it work if you use the fork (hdf5-metno-src
) at https://github.com/metno/hdf5-rust?
FYI: I'm following this issue but won't be contributing much to the discussion due to my very limited HDF5 knowledge.
I couldn't get it to work unfortunately though I think due to dependency conflicts rather then because of the code. I've solved the issue for now though by building on an older version of a platform that works without cross compiling.
Steps to reproduce
Relevant part (whole output in the bottom of the issue)
Simply invoking the same build command again completes the compilation and produces a statically linked binary
Proposed solution
Let user define the missing defines that generate the errors.
Simply adding the following to https://github.com/aldanor/hdf5-rust/blob/master/hdf5-src/build.rs allows the build to continue with no errors on first try (while running
cargo clean
prior):Full compiler failure output