search

aldas / modbus-tcp-client

PHP client for Modbus TCP and Modbus RTU over TCP (can be used for serial)
Apache License 2.0
196 stars 57 forks source link

Added `Packet::isCompleteLengthRTU()` #124

Closed aldas closed 2 years ago

aldas commented 2 years ago

Should help with https://github.com/aldas/modbus-tcp-client/discussions/123 and https://github.com/aldas/modbus-tcp-client/discussions/121

codecov[bot] commented 2 years ago

Codecov Report

Base: 99.09% // Head: 99.10% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (514be38) compared to base (39f874a). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #124 +/- ## ========================================= Coverage 99.09% 99.10% - Complexity 837 841 +4 ========================================= Files 68 68 Lines 1997 2007 +10 ========================================= + Hits 1979 1989 +10 Misses 18 18 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `99.10% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/aldas/modbus-tcp-client/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.) | Coverage Δ | | |---|---|---| | [src/Utils/Packet.php](https://codecov.io/gh/aldas/modbus-tcp-client/pull/124/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL1V0aWxzL1BhY2tldC5waHA=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.