search

aldeebhasan / lottie-laravel

This package will allow you to manage and preview lottie files in your laravel project
https://aldeebhasan.github.io/lottie-laravel
MIT License
6 stars 1 forks source link

avoid cdn #1

Open grafst opened 1 year ago

grafst commented 1 year ago

Hi Great Package, works like a charm. I would suggest avoiding pulling in the lottie.js file via cdn. Here are a couple of reasons why

I think best would be to use npm. that way it is also easy to upgrade.

aldeebhasan commented 1 year ago

Hi, thanks for your support, you are right, we need to find away to avoid cdn and any external resource loading. Using npm could solve the issue, but i dont want to add another steps in order to make the package work. i will check and do something regarding this possible enhancement

grafst commented 1 year ago

I respect that you don't want to add extra steps. Maybe this can help? https://freek.dev/2333-creating-installer-commands-for-laravel-packages Then just put the file in the package and update it every time lottie gets updated?