aldefouw / redcap_rsvc

REDCap Regulatory & Software Validation Committee (RSVC) - Automated validation feature test scripts
GNU General Public License v3.0
3 stars 6 forks source link

B.3.16.700 - Longitudinal Data Import #103

Open aldefouw opened 10 months ago

aldefouw commented 10 months ago

Feature: B.3.16.700 - Longitudinal Data Import

Feature Location: https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/B/Data%20Import/B.3.16.700%20-%20Longitudinal%20Data%20Import.feature

Task: Review Gherkin and adjust feature as necessary for syntax accuracy and test correctness.

phillidgithub commented 8 months ago

@aldefouw Please could you add the following files into fixtures > import_files B316700100_INACCURATE B3.16700100_ACCURATE

aldefouw commented 8 months ago

@phillidgithub

https://github.com/aldefouw/redcap_cypress/tree/master/cypress/fixtures/import_files

The files should be there now.

phillidgithub commented 7 months ago

The INACCURATE csv file behaves as expected. However, the ACCURATE csv file does not load correctly. See the attached screenshot.

Image

aldefouw commented 7 months ago

@phillidgithub - Thanks for letting me know. I'll have to check in with RSVC and see what might be the problem. In the meantime, if it would help you to move forward you can certainly fix it if you know how to proceed forward.

aldefouw commented 7 months ago

@phillidgithub

I looked into this and found that the files included in the REDCap project were incorrect. You can find the correct files here: https://github.com/aldefouw/redcap_rsvc/tree/v13.1.37/Files/import_files

In the long run, I'm going to start storing these import files with the redcap_rsvc repo so they can be tied to the features.

phillidgithub commented 7 months ago

I have run again using the new files. I still get the same error when uploading the ACCURATE csv file. Wondering if the data in both the INACCURATE and ACCURATE csv files is not in the correct format for import (something to do with real data fields no found - see above screenshot). Of course the INNACURATE file also lacks the event name which is expected.

aldefouw commented 7 months ago

@phillidgithub - Can you push your feature up to the CCTC-team fork of redcap_rsvc? If so, I can try running it locally and see what's going on.

aldefouw commented 6 months ago

@phillidgithub - I am reviewing this feature for you right now. I hope to have some answers soon.

aldefouw commented 6 months ago

@phillidgithub Incredibly frustrating problem, and I apologize it has taken so long for me to get to this.

What it boils down to is that the CDISC XML import file was wrong. The Project_1.xml we used in the redcap_cypress project was different than what the manual team used. They made some updates to theirs that were never merged into our automated version.

I've updated it to match what their files have. This explains some weird anomalies we were experiencing on other features too.

https://github.com/aldefouw/redcap_cypress/blob/master/cypress/fixtures/cdisc_files/Project_1.xml

Ultimately, you'll need to run git pull origin master on your redcap_cypress repo.

aldefouw commented 6 months ago

@phillidgithub - I found that what you had done was complete. The only problem was that the import XML file was incorrect, which was a problem with the redcap_cypress repo.

The end result is that I merged your feature into the branch, and I verified you have receiving credit for your commits and contributions.

https://github.com/aldefouw/redcap_rsvc/commits/v13.1.37/Feature%20Tests/B/Data%20Import/B.3.16.700%20-%20Longitudinal%20Data%20Import.feature

When you get a chance, can you write your hours spent in this issue? Resolution to 15 minutes. So, for 15 minutes, you'd write 0.25.

Let me know if you have any questions.

phillidgithub commented 6 months ago

Thank you @aldefouw Estimated time spent 1.5

minigojones commented 2 months ago

Actions taken on this Feature Test were reviewed and approved by RSVC leadership (Theresa Baker and Teresa Bosler) on 11-June-2024