search

aldefouw / redcap_rsvc

REDCap Regulatory & Software Validation Committee (RSVC) - Manual validation feature test scripts
GNU General Public License v3.0
2 stars 5 forks source link

B.5.21.100 - Export PHI #137

Open aldefouw opened 8 months ago

aldefouw commented 8 months ago

Feature: B.5.21.100 - Export PHI

Feature Location: https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/B/Export%20Data/B.5.21.100%20-%20Export%20PHI.feature

Task: Review Gherkin and adjust feature as necessary for syntax accuracy and test correctness.

minigojones commented 5 months ago

@aldefouw - @minigojones - self-assigning

minigojones commented 3 months ago

@aldefouw - handing back to you. Please address following:

  1. starting on line 40: how to account for bracket checkmark notation in "check for identifier" table
  2. Line 147: date entered will not pass since populating with NOW date, and this will vary according to testing time
  3. Line 159: Altering script to direct tester to Record Status Dashboard instead of Record Home Page
  4. starting on line 175: how to validate dates have shifted i.e., different from values entered.
trasuli0207 commented 1 month ago

@aldefouw looks like this may need a step def modification. I would love to see the fix for it with you. Is it easier for me to push my changes to you? What works best for you?

The line that is giving the issue is in the table line 22. I pulled Michelle's changes but do not see this listed as a problem in her comment. Maybe I did not pull from her branch correctly?

aldefouw commented 2 weeks ago

Merging in @minigojones work onto v13.1.37 branch. Will assess what next steps are.

aldefouw commented 2 weeks ago

@minigojones

@aldefouw - handing back to you. Please address following:

  1. starting on line 40: how to account for bracket checkmark notation in "check for identifier" table
  2. Line 147: date entered will not pass since populating with NOW date, and this will vary according to testing time
  3. Line 159: Altering script to direct tester to Record Status Dashboard instead of Record Home Page
  4. starting on line 175: how to validate dates have shifted i.e., different from values entered.

  1. Can we include in documentation? I am unsure how to represent a checkmark outside of a checkmark character.

  2. Addressed by using generic date format Regular Expression matching. Please see: https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/B/Export%20Data/B.5.21.100%20-%20Export%20PHI.feature#L148-L149

Putting a static date in here does not make sense so I think this is the only way that would make sense to verify.

  1. Completed. https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/B/Export%20Data/B.5.21.100%20-%20Export%20PHI.feature#L157-L158

  2. Still need to address the date shift. Hopefully can tackle tomorrow.

aldefouw commented 2 weeks ago

@minigojones

Here is the implementation for date shifts #4.

https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/B/Export%20Data/B.5.21.100%20-%20Export%20PHI.feature#L176-L180

aldefouw commented 2 weeks ago

Time: 3 hours (estimated)