search

aldefouw / redcap_rsvc

REDCap Regulatory & Software Validation Committee (RSVC) - Automated validation feature test scripts
GNU General Public License v3.0
3 stars 8 forks source link

C.2.19.200 - Lock form display #198

Open aldefouw opened 10 months ago

aldefouw commented 10 months ago

Feature: C.2.19.200 - Lock form display

Feature Location: https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/C/Record%20Locking%20&%20E-Signatures/C.2.19.200%20-%20Lock%20form%20display.feature

Task: Review Gherkin and adjust feature as necessary for syntax accuracy and test correctness.

trasuli0207 commented 7 months ago

@aldefouw taking over this test so I am commenting here :)

aldefouw commented 7 months ago

@trasuli0207 - I have added the ability for the table analysis step to interpret [✓] and [ ] as checked checkbox and unchecked checkbox, respectively.

The steps to pull in this functionality:

cd redcap_cypress
git pull origin master
npm install

You might have to restart Cypress. If it isn't working, verify that your package.json file in redcap_cypress has RCTF at 1.0.43:

"rctf": "git://github.com/aldefouw/rctf#v1.0.43"

A few notes:

  1. C.2.19.200 feature is also calling for "Notes Box & "Save" button" in a cell. 
|   [✓]     |    Text Validation  |     [ ]  | Notes Box & "Save" button  |

I don't think we want to have magic functions for every type of nested element. If we want to look for a save button, perhaps we just look for "Save" text instead? Maybe we can discuss during our meeting.

  1. Inconsistent use of checkbox designation:

Some other table analyzing steps include this:

|   [✓]    |    Text Validation    |     checkbox   |   Test custom text   |

If we are looking for an unchecked checkbox, use [ ]. If we are looking for checked checkbox, use [✓] .

trasuli0207 commented 7 months ago

@aldefouw pushed changes and hopefully we can figure out the step :) Thanks a ton for your help!

aldefouw commented 2 months ago

Take Tamana's fork and merge into v13.1.37: https://github.com/trasuli0207/redcap_rsvc/blob/v13.1.37/Feature%20Tests/C/Record%20Locking%20&%20E-Signatures/C.2.19.200%20-%20Lock%20form%20display.feature