search

aldefouw / redcap_rsvc

REDCap Regulatory & Software Validation Committee (RSVC) - Automated validation feature test scripts
GNU General Public License v3.0
3 stars 7 forks source link

A.4.8.100 - Enable field validation #69

Open aldefouw opened 11 months ago

aldefouw commented 11 months ago

Feature: A.4.8.100 - Enable field validation

Feature Location: https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/Field%20Validation/A.4.8.100%20-%20Enable%20field%20validation.feature

Task: Review Gherkin and adjust feature as necessary for syntax accuracy and test correctness.

aldefouw commented 11 months ago

Action Assertion Pattern not Followed https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/Field%20Validation/A.4.8.100%20-%20Enable%20field%20validation.feature#L24-L47

Completely different style of test where we are clicking Disable and verifying status. Follows standard action followed by assertion pattern instead of original version which clicked all the buttons and then verified these elements.

This is the only way I can do this on the automated side because I need to verify the graphic changed before I can actually move on to clicking the next button ...

Skipped step on Automated Version https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/Field%20Validation/A.4.8.100%20-%20Enable%20field%20validation.feature#L42-L43 Skipped this step because the default install already has this option disabled.

Robustness Improvement

https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/Field%20Validation/A.4.8.100%20-%20Enable%20field%20validation.feature#L59-L70

https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/Field%20Validation/A.4.8.100%20-%20Enable%20field%20validation.feature#L112-L131

Instead of looking for elements that do NOT exist (which we cannot actually prove), let's check for the elements that DO exist and look for every single option that should be there ...