search

aldefouw / redcap_rsvc

REDCap Regulatory & Software Validation Committee (RSVC) - Automated validation feature test scripts
GNU General Public License v3.0
3 stars 7 forks source link

A.3.26.100 - Public File Share #70

Open aldefouw opened 11 months ago

aldefouw commented 11 months ago

Feature: A.3.26.100 - Public File Share

Feature Location: https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/File%20Repository/A.3.26.100%20-%20Public%20File%20Share.feature

Task: Review Gherkin and adjust feature as necessary for syntax accuracy and test correctness.

aldefouw commented 11 months ago

https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/File%20Repository/A.3.26.100%20-%20Public%20File%20Share.feature#L29-L30

Note that we can select multiple files at one time in the File Repository by creating a dataTable below the step:

When I click the button labeled "Select files to upload" to select and upload the following file to the File Repository:
      |import_files/testusers_bulkupload.csv|

Added robustness by checking for more than the file name string: https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/File%20Repository/A.3.26.100%20-%20Public%20File%20Share.feature#L32-L37

    Then I should see a table header and rows containing the following values in the file repository table:
       | Name                     | Time Uploaded    | Comments                |
       | Data Export Files        |                  |                         |
       | PDF Survey Archive       |                  |                         |
       | Recycle Bin              |                  |                         |
       | testusers_bulkupload.csv | mm/dd/yyyy hh:mm | Uploaded by test_admin. |

https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/File%20Repository/A.3.26.100%20-%20Public%20File%20Share.feature#L58

Note that manual test did not close the dialog box before moving onto the next step. That doesn't work at all for ATS but it would be a good idea to add this to manual in my opinion:

And I click on the button labeled "Close" in the dialog box

Note how we deal with the icons specified:

https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/File%20Repository/A.3.26.100%20-%20Public%20File%20Share.feature#L55

https://github.com/aldefouw/redcap_rsvc/blob/v13.1.37/Feature%20Tests/A/File%20Repository/A.3.26.100%20-%20Public%20File%20Share.feature#L74

Given I click on the File Share icon for the File Repository file named "testusers_bulkupload.csv"

This type of step will work for any file that is in the File Repo.