search

aldelaro5 / dolphin-memory-engine

A RAM search made specifically to search, monitor and edit the Dolphin emulator's emulated memory
MIT License
158 stars 36 forks source link

Add Clang-Tidy configuration file + a some fixes. #125

Closed cristian64 closed 1 month ago

cristian64 commented 1 month ago

A .clang-tidy file has been added to the repository (next to the .clang-format file).

A subset of the enabled warning types have been addressed.

cristian64 commented 1 month ago

Discovered the hard way that std::bit_cast is not available in the C++20 feature subset that GCC 10 implements. I am on GCC 11 in my system, so I didn't notice. A hand-rolled implementation has been added; checks are now passing.

dreamsyntax commented 1 month ago

Do you have a preference on if this is squashed into one commit on merge, or prefer them rebased onto the repo as is?

image

cristian64 commented 1 month ago

My preference is to rebase and merge without squashing (it'd be a pity to lose the info I put in the description in each of the commits).