search

aldelaro5 / dolphin-memory-engine

A RAM search made specifically to search, monitor and edit the Dolphin emulator's emulated memory
MIT License
158 stars 36 forks source link

Support array-of-bytes binary display #126

Closed malleoz closed 1 month ago

malleoz commented 1 month ago

Viewing an array of bytes entry as binary can be especially useful when observing bitfields. For example, Mario Kart Wii uses bitfields to track whether we are accelerating, braking, drifting, tricking, etc. Being able to view each bit in the field makes viewing the current state of each scenario a bit easier!

I didn't add octal or decimal support, because I can't imagine any scenarios where such a display could be useful.

cristian64 commented 1 month ago

I've given it a go, and it works well. I've added a few comments, but I wouldn't be against to get it merged in its current state.

(The macOS error appears to be unrelated; might need to retry.)

malleoz commented 1 month ago

@cristian64 I don't see your comments. Do you have a pending review that you forgot to click "Submit review" for?

malleoz commented 1 month ago

Those changes seem to work fine on my end, so I'm all for cleaning it up!